Skip to content

Commit

Permalink
Fixes MAISTRA-1167: RetryHostPredicateFilter in protocol_integration_…
Browse files Browse the repository at this point in the history
…test suite passes now (maistra#3)
  • Loading branch information
Dmitri Dolguikh authored and dmitri-d committed Mar 9, 2020
1 parent 9e24d37 commit 61b3080
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
4 changes: 1 addition & 3 deletions test/integration/protocol_integration_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -387,13 +387,11 @@ TEST_P(DownstreamProtocolIntegrationTest, RetryPriority) {
EXPECT_EQ(512U, response->body().size());
}

// TODO (dmitri-d) fix "An queued upstream connection was torn down without being associated with a fake connection"
//
// Verifies that a retry host filter can be configured and affect the host selected during retries.
// The predicate will keep track of the first host attempted, and attempt to route all requests to
// the same host. With a total of two upstream hosts, this should result in us continuously sending
// requests to the same host.
TEST_P(DownstreamProtocolIntegrationTest, DISABLED_RetryHostPredicateFilter) {
TEST_P(DownstreamProtocolIntegrationTest, RetryHostPredicateFilter) {
TestHostPredicateFactory predicate_factory;
Registry::InjectFactory<Upstream::RetryHostPredicateFactory> inject_factory(predicate_factory);

Expand Down
2 changes: 1 addition & 1 deletion test/test_common/utility.h
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,7 @@ class TestUtility {
static std::string convertTime(const std::string& input, const std::string& input_format,
const std::string& output_format);

static constexpr std::chrono::milliseconds DefaultTimeout = std::chrono::milliseconds(30000);
static constexpr std::chrono::milliseconds DefaultTimeout = std::chrono::milliseconds(10000);

static void renameFile(const std::string& old_name, const std::string& new_name);
static void createDirectory(const std::string& name);
Expand Down

0 comments on commit 61b3080

Please sign in to comment.