Bds b1c gsoc2022 #6
Conversation
Signed-off-by: Joan Miguel Bernabeu Frias <[email protected]>
| * \brief Adapts a PCPS acquisition block to an Acquisition Interface for | ||
| * BEIDOU B1C signals | ||
| * \authors <ul> | ||
| * <li> Andrew Kamble, 2019. [email protected] |
There was a problem hiding this comment.
Make sure to add your info here as you also developed this code
| * \brief Adapts a PCPS acquisition block to an AcquisitionInterface for | ||
| * BEIDOU B1C signals | ||
| * \authors <ul> | ||
| * <li> Andrew Kamble, 2019. [email protected] |
There was a problem hiding this comment.
Same as before, improve the doc by adding your contact info and a headline about GSoC 2022
Signed-off-by: Joan Miguel Bernabeu Frias <[email protected]>
Signed-off-by: Joan Miguel Bernabeu Frias <[email protected]>
Signed-off-by: Joan Miguel Bernabeu Frias <[email protected]>
|
I am trying to fix the build process. There's some error concerning the way gnss factory imports b1cPcps acquisition adapter that I am still to solve. |
Signed-off-by: Joan Miguel Bernabeu Frias <[email protected]>
Signed-off-by: Joan Miguel Bernabeu Frias <[email protected]>
| @@ -324,6 +325,7 @@ std::unique_ptr<GNSSBlockInterface> GNSSBlockFactory::GetObservables(const Confi | |||
| Glonass_channels += configuration->property("Channels_2G.count", 0); | |||
| unsigned int Beidou_channels = configuration->property("Channels_B1.count", 0); | |||
| Beidou_channels += configuration->property("Channels_B3.count", 0); | |||
| Beidou_channels += configuration->property("Channels_BC.count", 0); | |||
There was a problem hiding this comment.
I am not sure about the 'BC' nomenclature. I think all signals use a letter and number approach, like B3, 2G, etc. Is this the case always? if yes, please change to its original identification of 1C
| * BEIDOU B1C signals | ||
| * \authors <ul> | ||
| * <li> Andrew Kamble, 2019. [email protected] | ||
| * <li> Joan Bernabeu, 2022. [email protected] |
There was a problem hiding this comment.
I was also an author, please also add my info here. I normally do not ask for this, but because your merge copies and paste code, and remove all previous history, you need to be extra careful here.
| * \file beidou_b1c_dll_pll_tracking.cc | ||
| * \brief Interface of an adapter of a DLL+PLL tracking loop block | ||
| * for BEIDOU B1C to a TrackingInterface | ||
| * \author Andrew Kamble, 2019. [email protected] |
There was a problem hiding this comment.
Have you worked with this file? If so, remember the author's information.
Also. why .cpp? I think all files should be .cc extension
| @@ -463,6 +467,7 @@ std::unique_ptr<std::vector<std::unique_ptr<GNSSBlockInterface>>> GNSSBlockFacto | |||
| Channels_L5_count + | |||
| Channels_B1_count + | |||
| Channels_B3_count + | |||
| Channels_BC_count + | |||
There was a problem hiding this comment.
multiple + sign? This should be a build error
src/main/CMakeLists.txt
Outdated
| @@ -1,4 +1,4 @@ | |||
| # GNSS-SDR is a Global Navigation Satellite System software-defined receiver. | |||
| # gnss-sdr is a Global Navigation Satellite System software-defined receiver. | |||
There was a problem hiding this comment.
This needs to be capital letters. Please avoid changing comments in CMakeLists.txt files if possible
| @@ -0,0 +1,3 @@ | |||
| // | |||
There was a problem hiding this comment.
same comment with .cpp vs .cc
Signed-off-by: Joan Miguel Bernabeu Frias <[email protected]>
Signed-off-by: Joan Miguel Bernabeu Frias <[email protected]>
Signed-off-by: Joan Miguel Bernabeu Frias <[email protected]>
Signed-off-by: Joan Miguel Bernabeu Frias <[email protected]>
… of the Acquisition. Acquisition validation pending. Signed-off-by: Joan Miguel Bernabeu Frias <[email protected]>
Signed-off-by: Joan Miguel Bernabeu Frias <[email protected]>
Signed-off-by: Joan Miguel Bernabeu Frias <[email protected]>
Signed-off-by: Joan Miguel Bernabeu Frias <[email protected]>
…lot signal Signed-off-by: Joan Miguel Bernabeu Frias <[email protected]>
Signed-off-by: Joan Miguel Bernabeu Frias <[email protected]>
…g b1i implementation Signed-off-by: Joan Miguel Bernabeu Frias <[email protected]>
Signed-off-by: Joan Miguel Bernabeu Frias <[email protected]>
…the pilot/data structure Signed-off-by: Joan Miguel Bernabeu Frias <[email protected]>
Signed-off-by: Joan Miguel Bernabeu Frias <[email protected]>
Signed-off-by: Joan Miguel Bernabeu Frias <[email protected]>
…)) encoding Signed-off-by: Joan Miguel Bernabeu Frias <[email protected]>
…ated correctly, following B1C's ICD Signed-off-by: Joan Miguel Bernabeu Frias <[email protected]>
…y codes: Most changes have addressed indexation and loop ranges. Signed-off-by: Joan Miguel Bernabeu Frias <[email protected]>
…g track of the files dumped to it Signed-off-by: Joan Miguel Bernabeu Frias <[email protected]>
Signed-off-by: Joan Miguel Bernabeu Frias <[email protected]>
Signed-off-by: Joan Miguel Bernabeu Frias <[email protected]>
…or_length parameter which had a default value of 0 Signed-off-by: Joan Miguel Bernabeu Frias <[email protected]>
Signed-off-by: Joan Miguel Bernabeu Frias <[email protected]>
…_acq for a better selection of acq dumps Signed-off-by: Joan Miguel Bernabeu Frias <[email protected]>
Signed-off-by: Joan Miguel Bernabeu Frias <[email protected]>
Signed-off-by: Joan Miguel Bernabeu Frias <[email protected]>
Signed-off-by: Joan <[email protected]>
👍🎉 Hello, and thanks for contributing to
GNSS-SDR! 🎉👍
Any code contributions going into GNSS-SDR will become part of a GPL-licensed,
open source repository. It is therefore imperative that code submissions belong
to the authors, and that submitters have the authority to merge that code into
the public GNSS-SDR codebase.
For that purpose, we use the
Developer's Certificate of Origin.
It is the same document used by other projects. Signing the DCO states that
there are no legal reasons to not merge your code.
To sign the DCO, suffix your git commits with a
Signed-off-by:line. Whenusing the command line, you can use
git commit -sto automatically add thisline. If there were multiple authors of the code, or other types of
stakeholders, make sure that all are listed, each with a separate
Signed-off-by:line.Before submitting your pull request, please make sure the following is done:
Contributor Covenant Code of Conduct.
Developer's Certificate of Origin
and
signed your commits
as an indication of fulfillment.
Contributing Guidelines.
Specifically, you have read
about clang-format
and about clang-tidy,
and you have applied those tools to your changes.
gnss-sdr upstream repository and
have created your branch from
next(or any other currently living branchin the upstream repository).
Please feel free to delete this line and the above text once you have read it
and in case you want to go on with your pull request, and explain your intend
below.