WIP: Generate Spack resource statements #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, please let me know when it'll be ready to be merged. |
I made a hard fork early, thought I'd cleaned it all up, but missed these. Add a test that resolves to a private GitLab repo.
I've reworked the Spack prototype to inhale a JSON array of objects. This updated the spack output to be, wait for it..., a JSON array of objects.... With tests.
17 tasks
|
By way of an update, the Spack PR isn't getting timely feedback, so this is on hold until it gets moving again. Thank you for being willing to see the use cases expanded! |
dmgk
force-pushed
the
master
branch
8 times, most recently
from
c361e44 to
1f184ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress, not ready to be merged. It might change with feedback from @dmgk and/or the Spack community.
This adds support for generating Spack resource statements, in support of adding general support for Go applications to Spack. It:
-spackand-app_version)-spackis provided on the command line, including awhen=...attribute if-app_versionis provided.when=attribute, and differentiating between thecommit=andtag=commit depending on the format of the version identifier.Closes #7