Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for running under setup.py/manage.py and travis setup. #8

Merged
merged 3 commits into from
Feb 24, 2015

Conversation

mdprewitt
Copy link
Contributor

I'm closing out #7 and moving the commits to this PR. I basically rearranged the commits to make more sense. The only additional changes on this PR are fully working tests for running under django_nose and as setup.py nosetests.

The nosepipe plugin wasn't working when running under setup.py or manage.py (django with django_nose). It would fail because the subprocesses would be run as setup.py/manage.py instead of nosetests processes. The output from the sub-process was confusing nosetests. So, when running under something other than nosetests, nosetests needs to make sure the sub-process command is nosetests... instead of setup.py nosetests...

I also had dependency problems with nose==dev in setup.py. Getting the following error:

python setup.py develop
...
No local packages or download links found for nose==dev,>=0.1.0
error: Could not find suitable distribution for Requirement.parse('nose==dev,>=0.1.0')

This seems to be due to the dependency being ==dev AND >=0.1.0 which doesn't seem to be able to be true. I removed the ==dev but added a travis test case to specifically use the dev version of nose.

Finally, I added a .travis.yml which will make it simple to add automated CI jobs using http://travis-ci.org if you 'd like. See the tests running from my fork here:

https://travis-ci.org/mdprewitt/nosepipe

Marc Prewitt added 3 commits February 19, 2015 13:15
- .travis.yml to run CI tests on travis
- .gitignore: add vim tmp files, eggs and others installed by setup.py
- nosepipe.py: ProcessIsolationPlugin.configure, if coverage plugin isn't
  installed don't try to configure for it
- setup.py: remove nose==dev dependency as nose-dev seems to distribute
  'dev' with a version number.  Testing with dev is done by
  pre-installing a dev version in the travis setup script.
- nosepipe.py: If we're not running as `nosetests` change the
  sub-process to run as nosetests.  Other non-nosetests scripts like
  setup.py/manage.py obscure the output of tests such that nosetests
  can't parse the output correctly.
- add test-support/django sample project for testing django-nose
@dmccombs
Copy link
Owner

This looks good to me. Thanks!

dmccombs pushed a commit that referenced this pull request Feb 24, 2015
Support for running under setup.py/manage.py and travis setup.
@dmccombs dmccombs merged commit ea1092e into dmccombs:master Feb 24, 2015
@ashald ashald mentioned this pull request Mar 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants