Refactor builders

dmandalidis · Dec 21, 2024 · 36e3b90 · 36e3b90
1 parent 1d9f3c4
commit 36e3b90
Show file tree

Hide file tree

Showing 9 changed files with 367 additions and 524 deletions.
diff --git a/README.md b/README.md
@@ -35,7 +35,7 @@ Download the latest JAR or grab [via Maven][maven-search]
 
 ```java
 // Create a client based on DOCKER_HOST and DOCKER_CERT_PATH env vars
-final DockerClient docker = new JerseyDockerClientBuilder().fromEnv().build();
+final DockerClient docker = DockerClientBuilder.fromEnv().build();
 
 // Pull an image
 docker.pull("busybox");

diff --git a/pom.xml b/pom.xml
@@ -129,8 +129,6 @@
 			<scope>provided</scope>
 		</dependency>
 
-		<!--optional deps -->
-		<!-- TODO we should pull out the Google Cloud support to a new library -->
 		<dependency>
 			<groupId>com.google.auth</groupId>
 			<artifactId>google-auth-library-oauth2-http</artifactId>

diff --git a/src/main/java/org/mandas/docker/client/builder/BaseDockerClientBuilder.java b/src/main/java/org/mandas/docker/client/builder/BaseDockerClientBuilder.java