Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable global telemetry by default + channel buffer size up to 8192 #840

Merged
merged 2 commits into from
Oct 9, 2024
Merged

disable global telemetry by default + channel buffer size up to 8192 #840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8680524
disable global telemetry by default
dmachard Oct 9, 2024
f5b67ec
update docs
dmachard Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ global:
interval-monitor: 10
buffer-size: 4096
telemetry:
enabled: true
enabled: false
web-path: "/metrics"
web-listen: ":9165"
prometheus-prefix: "dnscollector_exporter"
Expand Down
4 changes: 2 additions & 2 deletions docs/configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ The `buffer-size` settings enable to adjust the size of the buffer before discar
global:
worker:
interval-monitor: 10
buffer-size: 4096
buffer-size: 8192
```

## Custom text format
Expand Down Expand Up @@ -182,7 +182,7 @@ Enable and configure telemetry
```yaml
global:
telemetry:
enabled: true
enabled: false
web-path: "/metrics"
web-listen: ":9165"
prometheus-prefix: "dnscollector_exporter"
Expand Down
4 changes: 2 additions & 2 deletions pkgconfig/global.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ type ConfigGlobal struct {
PidFile string `yaml:"pid-file" default:""`
Worker struct {
InternalMonitor int `yaml:"interval-monitor" default:"10"`
ChannelBufferSize int `yaml:"buffer-size" default:"4096"`
ChannelBufferSize int `yaml:"buffer-size" default:"8192"`
} `yaml:"worker"`
Telemetry struct {
Enabled bool `yaml:"enabled" default:"true"`
Enabled bool `yaml:"enabled" default:"false"`
WebPath string `yaml:"web-path" default:"/metrics"`
WebListen string `yaml:"web-listen" default:":9165"`
PromPrefix string `yaml:"prometheus-prefix" default:"dnscollector_exporter"`
Expand Down
Loading