-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redesign config checker to support freeform keys #678
Conversation
@pieterlexis-tomtom I would like to add you as reviewer but I cannot. Any feedback will be appreciated (if you can) |
I'll have a look, but I must say I am not well-versed with |
No worries, or just some tests will be great too. |
This seems to work well on a few configs I tried 👍. Good stuff! |
If I can point to an improvement: You're reading the config file multiple times while loading (first for config, then checking), perhaps you should read it once and use the |
thanks, changed done! |
fix #676
Individual function
IsValid
has been added to the following structs:The config checker support freeform keys and the code is more easy to maintain!