Add length checks for resource record parsing #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since RDATA can contain variable-length data, this ensures we will not read past the end of RDATA buffer when parsing it. Compressed labels can contain pointers only to prior data, thus full payload is not needed for parsing labels. Only the prior data.
Use net.IP to format the textual representation of addresses.
Offset needs to be updated to allow us continue parsing the next recrods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds necessary length checks for parsing resource records to ensure RDATA contains enough data. This prevents dns-collector from panicking if DNS packets containing invalid resource records are received.
The A and AAAA record parsing now uses
net.IPto print address as text, this changes the output for IPv6 address to be the compressed format of the address. Please let me know if this is not ok, and I'll change it back to print the long format.This PR also contains fix for a bug prevented parsing any resource record after OPT record.