Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.12.0 crash - stack overflow #15

Closed
RonV666 opened this issue Nov 30, 2021 · 7 comments
Closed

0.12.0 crash - stack overflow #15

RonV666 opened this issue Nov 30, 2021 · 7 comments
Labels
bug Something isn't working
Milestone

Comments

@RonV666
Copy link

RonV666 commented Nov 30, 2021

Running 0.12.0 binary I get a stack overflow after a few seconds of runtime. Tested on Fedora 35 and vanilla Ubuntu 20.04

Nov 30 22:49:11 protobuf go-dnscollector[2238]: runtime: goroutine stack exceeds 1000000000-byte limit
Nov 30 22:49:11 protobuf go-dnscollector[2238]: runtime: sp=0xc020380390 stack=[0xc020380000, 0xc040380000]
Nov 30 22:49:11 protobuf go-dnscollector[2238]: fatal error: stack overflow
Nov 30 22:49:11 protobuf go-dnscollector[2238]: runtime stack:
Nov 30 22:49:11 protobuf go-dnscollector[2238]: runtime.throw({0x9cb67f, 0xe00220})
Nov 30 22:49:11 protobuf go-dnscollector[2238]: #11/opt/hostedtoolcache/go/1.17.3/x64/src/runtime/panic.go:1198 +0x71
Nov 30 22:49:11 protobuf go-dnscollector[2238]: runtime.newstack()
Nov 30 22:49:11 protobuf go-dnscollector[2238]: #11/opt/hostedtoolcache/go/1.17.3/x64/src/runtime/stack.go:1088 +0x5ac
Nov 30 22:49:11 protobuf go-dnscollector[2238]: runtime.morestack()
Nov 30 22:49:11 protobuf go-dnscollector[2238]: #11/opt/hostedtoolcache/go/1.17.3/x64/src/runtime/asm_amd64.s:461 +0x8b
Nov 30 22:49:11 protobuf go-dnscollector[2238]: goroutine 21 [running]:
Nov 30 22:49:11 protobuf go-dnscollector[2238]: runtime.heapBitsSetType(0xc009804f50, 0x10, 0x10, 0x901880)

config file:

trace:
verbose: false

collectors:
dnstap:
enable: true
listen-ip: 0.0.0.0
listen-port: 6000
tls-support: false

loggers:
logfile:
enable: true
file-path: "/var/log/dnstap.log"
max-size: 100
max-files: 20
mode: json

@dmachard
Copy link
Owner

dmachard commented Dec 1, 2021

0.12.0-crash.txt

@dmachard dmachard added the bug Something isn't working label Dec 1, 2021
@dmachard
Copy link
Owner

dmachard commented Dec 1, 2021

Can you share a network dump with DNS packets ?
I suspect this crash is caused by a badly decoded packet, but so far I don't succeed to reproduce in my side .

@RonV666
Copy link
Author

RonV666 commented Dec 1, 2021

hello, thank you, shared by email for relative confidentiality of data.

dmachard added a commit that referenced this issue Dec 1, 2021
@dmachard
Copy link
Owner

dmachard commented Dec 1, 2021

Can you try this new beta release https://github.com/dmachard/go-dnscollector/releases/tag/v0.12.0-b2 ?

@dmachard dmachard added this to the 0.12.0 milestone Dec 1, 2021
@RonV666
Copy link
Author

RonV666 commented Dec 2, 2021

so far so good, running for about 10 hours so far

@dmachard
Copy link
Owner

dmachard commented Dec 2, 2021

good news :) thank for testing

@RonV666
Copy link
Author

RonV666 commented Dec 3, 2021

still going strong.

@dmachard dmachard closed this as completed Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants