fix flag rd condition

dmachard · Dec 3, 2024 · fba459e · fba459e
1 parent dc62a7e
commit fba459e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/dnsutils/dnsmessage_text.go b/dnsutils/dnsmessage_text.go
@@ -463,7 +463,7 @@ func (dm *DNSMessage) ToTextLine(format []string, fieldDelimiter string, fieldBo
 				s.WriteByte('-')
 			}
 		case directive == "rd":
-			if flags.AD {
+			if flags.RD {
 				s.WriteString("RD")
 			} else {
 				s.WriteByte('-')

diff --git a/dnsutils/dnsmessage_text_test.go b/dnsutils/dnsmessage_text_test.go
@@ -188,9 +188,14 @@ func TestDnsMessage_TextFormat_DefaultDirectives(t *testing.T) {
 			expected: "PKTERR",
 		},
 		{
-			format:   "tc aa ra ad rd",
-			dm:       DNSMessage{DNS: DNS{Flags: DNSFlags{TC: true, AA: true, RA: true, AD: true, RD: true}}},
-			expected: "TC AA RA AD RD",
+			format:   "tc aa ra ad",
+			dm:       DNSMessage{DNS: DNS{Flags: DNSFlags{TC: true, AA: true, RA: true, AD: true}}},
+			expected: "TC AA RA AD",
+		},
+		{
+			format:   "rd",
+			dm:       DNSMessage{DNS: DNS{Flags: DNSFlags{RD: true}}},
+			expected: "RD",
 		},
 		{
 			format:   "tc aa ra ad rd",