allows naming conventions to be changed

dlt/common/configuration/specs/base_configuration.py

@@ -197,11 +197,13 @@ def default_factory(att_value=att_value):  # type: ignore[no-untyped-def]
 
 @configspec
 class BaseConfiguration(MutableMapping[str, Any]):
-    __is_resolved__: bool = dataclasses.field(default=False, init=False, repr=False)
+    __is_resolved__: bool = dataclasses.field(default=False, init=False, repr=False, compare=False)
     """True when all config fields were resolved and have a specified value type"""
-    __section__: str = dataclasses.field(default=None, init=False, repr=False)
+    __section__: str = dataclasses.field(default=None, init=False, repr=False, compare=False)
     """Obligatory section used by config providers when searching for keys, always present in the search path"""
-    __exception__: Exception = dataclasses.field(default=None, init=False, repr=False)
+    __exception__: Exception = dataclasses.field(
+        default=None, init=False, repr=False, compare=False
+    )
     """Holds the exception that prevented the full resolution"""
     __config_gen_annotations__: ClassVar[List[str]] = []
     """Additional annotations for config generator, currently holds a list of fields of interest that have defaults"""

dlt/common/data_writers/__init__.py

@@ -3,7 +3,7 @@
 from dlt.common.data_writers.escape import (
     escape_redshift_literal,
     escape_redshift_identifier,
-    escape_bigquery_identifier,
+    escape_hive_identifier,
 )
 
 __all__ = [
@@ -14,5 +14,5 @@
     "new_file_id",
     "escape_redshift_literal",
     "escape_redshift_identifier",
-    "escape_bigquery_identifier",
+    "escape_hive_identifier",
 ]

dlt/common/data_writers/escape.py

@@ -121,18 +121,18 @@ def escape_redshift_identifier(v: str) -> str:
 escape_athena_identifier = escape_postgres_identifier
 
 
-def escape_bigquery_identifier(v: str) -> str:
+def escape_hive_identifier(v: str) -> str:
     # https://cloud.google.com/bigquery/docs/reference/standard-sql/lexical
     return "`" + v.replace("\\", "\\\\").replace("`", "\\`") + "`"
 
 
 def escape_snowflake_identifier(v: str) -> str:
     # Snowcase uppercase all identifiers unless quoted. Match this here so queries on information schema work without issue
     # See also https://docs.snowflake.com/en/sql-reference/identifiers-syntax#double-quoted-identifiers
-    return escape_postgres_identifier(v.upper())
+    return escape_postgres_identifier(v)
 
 
-escape_databricks_identifier = escape_bigquery_identifier
+escape_databricks_identifier = escape_hive_identifier
 
 
 DATABRICKS_ESCAPE_DICT = {"'": "\\'", "\\": "\\\\", "\n": "\\n", "\r": "\\r"}

dlt/common/destination/capabilities.py

@@ -1,12 +1,10 @@
-from typing import Any, Callable, ClassVar, List, Literal, Optional, Tuple, Set, get_args
+from typing import Any, Callable, ClassVar, List, Literal, Optional, Tuple, Set, Union, get_args
 
 from dlt.common.configuration.utils import serialize_value
 from dlt.common.configuration import configspec
 from dlt.common.configuration.specs import ContainerInjectableContext
-from dlt.common.utils import identity
-
 from dlt.common.arithmetics import DEFAULT_NUMERIC_PRECISION, DEFAULT_NUMERIC_SCALE
-
+from dlt.common.normalizers.naming import NamingConvention
 from dlt.common.wei import EVM_DECIMAL_PRECISION
 
 # known loader file formats
@@ -35,7 +33,13 @@ class DestinationCapabilitiesContext(ContainerInjectableContext):
     preferred_staging_file_format: Optional[TLoaderFileFormat]
     supported_staging_file_formats: List[TLoaderFileFormat]
     escape_identifier: Callable[[str], str]
+    "Escapes table name, column name and other identifiers"
     escape_literal: Callable[[Any], Any]
+    "Escapes string literal"
+    casefold_identifier: Callable[[str], str] = str
+    """Casing function applied by destination to represent case insensitive identifiers."""
+    has_case_sensitive_identifiers: bool
+    """Tells if identifiers in destination are case sensitive, before case_identifier function is applied"""
     decimal_precision: Tuple[int, int]
     wei_precision: Tuple[int, int]
     max_identifier_length: int
@@ -46,7 +50,7 @@ class DestinationCapabilitiesContext(ContainerInjectableContext):
     is_max_text_data_type_length_in_bytes: bool
     supports_transactions: bool
     supports_ddl_transactions: bool
-    naming_convention: str = "snake_case"
+    naming_convention: Union[str, NamingConvention] = "snake_case"
     alter_add_multi_column: bool = True
     supports_truncate_command: bool = True
     schema_supports_numeric_precision: bool = True
@@ -63,14 +67,18 @@ class DestinationCapabilitiesContext(ContainerInjectableContext):
     @staticmethod
     def generic_capabilities(
         preferred_loader_file_format: TLoaderFileFormat = None,
+        naming_convention: Union[str, NamingConvention] = None,
     ) -> "DestinationCapabilitiesContext":
         caps = DestinationCapabilitiesContext()
         caps.preferred_loader_file_format = preferred_loader_file_format
         caps.supported_loader_file_formats = ["jsonl", "insert_values", "parquet"]
         caps.preferred_staging_file_format = None
         caps.supported_staging_file_formats = []
-        caps.escape_identifier = identity
+        caps.naming_convention = naming_convention or caps.naming_convention
+        caps.escape_identifier = str
         caps.escape_literal = serialize_value
+        caps.casefold_identifier = str
+        caps.has_case_sensitive_identifiers = True
         caps.decimal_precision = (DEFAULT_NUMERIC_PRECISION, DEFAULT_NUMERIC_SCALE)
         caps.wei_precision = (EVM_DECIMAL_PRECISION, 0)
         caps.max_identifier_length = 65536