Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/2251-use vectorized scanner #2329

Merged
merged 7 commits into from
Feb 26, 2025
Merged

Feat/2251-use vectorized scanner #2329

merged 7 commits into from
Feb 26, 2025

Conversation

anuunchin
Copy link
Contributor

Description

This PR enables the vectorized scanner for Parquet files when loading to Snowflake. the ON_ERROR setting defaults to ABORT_STATEMENT.

Related Issues

@netlify Netlify
Copy link

netlify bot commented Feb 18, 2025 •
edited
Loading

✅ Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit a712c18
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/67bd807ca40c280008b10888
😎 Deploy Preview https://deploy-preview-2329--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rudolfix
rudolfix previously requested changes Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this good! thx for writing test and docs. please see my comments on testing all data types

@anuunchin anuunchin force-pushed the feat/use-vectorized-scanner branch from d5bf710 to f5d2bd1 Compare February 20, 2025 09:53
@anuunchin anuunchin requested a review from rudolfix February 20, 2025 09:54
sh-rp
sh-rp approved these changes Feb 24, 2025
View reviewed changes
Copy link
Collaborator

@sh-rp sh-rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! somehow the docs are not building, you'll have to investigate

@anuunchin anuunchin dismissed rudolfix’s stale review February 25, 2025 08:20

Not dismissing, but already incorporated and reviewed by Dave.

@anuunchin anuunchin force-pushed the feat/use-vectorized-scanner branch from f5d2bd1 to a712c18 Compare February 25, 2025 08:34
@anuunchin
Copy link
Contributor Author

lgtm! somehow the docs are not building, you'll have to investigate

There was an img not found error, so I rebased - should be fine now 👓

rudolfix
rudolfix approved these changes Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! and thanks for a good test and docs

@sh-rp sh-rp merged commit 667b154 into devel Feb 26, 2025
71 of 72 checks passed
@sh-rp sh-rp deleted the feat/use-vectorized-scanner branch February 26, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sh-rp sh-rp sh-rp approved these changes

@rudolfix rudolfix rudolfix approved these changes

@VioletM VioletM Awaiting requested review from VioletM

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use USE_VECTORIZED_SCANNER=True for loading parquet files to Snowflake
3 participants
@anuunchin @sh-rp @rudolfix