historic docs v2 #1770
historic docs v2 #1770
Conversation
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rudolfix
added
the
sprint
| const selectedVersions = ["master"]; | ||
| let lastVersion = versions[0]; | ||
| for (let ver of versions) { | ||
| if (semver.minor(ver) != semver.minor(lastVersion) || semver.major(ver) != semver.major(lastVersion)) { |
There was a problem hiding this comment.
I do not want to nitpick but this works correctly for 0.x.x version. For 1.x.x we want to keep only
1,x,x,
2,x,x
tldr;> check only the difference on major
| VERSIONED_SIDEBARS_FOLDER = "versioned_sidebars" | ||
|
|
||
| // no doc versions below this version will be deployed | ||
| MINIMUM_SEMVER_VERSION = "0.4.0" |
|
|
||
| // go through the versions and find all newest versions of minor versions | ||
| const selectedVersions = ["master"]; | ||
| let lastVersion = versions[0]; |
There was a problem hiding this comment.
can we add 0.5.4 (latest) to the top tag?
| console.log("Checking branch") | ||
| const branch = proc.execSync(`cd ${REPO_DIR} && git rev-parse --abbrev-ref HEAD`).toString().trim() | ||
|
|
||
| if (branch != "devel") { |
There was a problem hiding this comment.
I think I do not understand this part. We should not use the REPO_DIR to build the current (development) docs. What IMO we should do:
- what we call
develwe should build using the already checked out repo including uncommitted local changes. this will also allow to build previews for PRs (or this already works like that? because we still build local docs) - the highest tag found should not be built from this tag but from
master. this will allow to update docs in master branch and get then online without increasing the tag
There was a problem hiding this comment.
Yes, this is how it works, this line only is a sanity check wether the repo could be checked out properly. the devel branch of the checked out repo never actually is built, check further down, it only ever builds stuff collected in the versions.
sh-rp
force-pushed
the
feat/1712-historic-docs-v2
branch
from
2c49693 to
48fa9d4
Compare
sh-rp
force-pushed
the
feat/1712-historic-docs-v2
branch
from
48fa9d4 to
cb9c44c
Compare
Description
PR for adding historic docs without checking these historic docs into the repo. Mechanism:
TODO after merging: