Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor filesystem doc #1745

Merged
merged 7 commits into from
Sep 12, 2024
Merged

Refactor filesystem doc #1745

merged 7 commits into from
Sep 12, 2024

Conversation

VioletM
Copy link
Contributor

@VioletM VioletM commented Aug 26, 2024

No description provided.

@VioletM VioletM linked an issue Aug 26, 2024 that may be closed by this pull request
3 tasks
Copy link

netlify bot commented Aug 26, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit 4dfce16
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/66e1cf7b309cde00083a3396
😎 Deploy Preview https://deploy-preview-1745--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@VioletM VioletM force-pushed the docs/1719-filesystem branch from 7af9930 to 7541090 Compare August 26, 2024 16:29
@VioletM VioletM requested review from akelad and mariarice15 August 26, 2024 16:44
@VioletM VioletM force-pushed the docs/1719-filesystem branch from 7541090 to 61f6a9c Compare August 26, 2024 16:55
@VioletM VioletM linked an issue Aug 28, 2024 that may be closed by this pull request
@VioletM VioletM force-pushed the docs/1719-filesystem branch 2 times, most recently from 47386c9 to d1f5d56 Compare September 1, 2024 18:46
@sh-rp sh-rp added the documentation Improvements or additions to documentation label Sep 2, 2024
@rudolfix rudolfix added the sprint Marks group of tasks with core team focus at this moment label Sep 2, 2024
@@ -0,0 +1,18 @@
---
title: Filesystem & Buckets
description: dlt verified source for Filesystem & Buckets
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we say core source instead of verified source btw?

keywords: [readers source and filesystem, files, filesystem, readers source, cloud storage]
---

The Filesystem source is a generic source that allows seamless loading files from the following locations:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw i'm also not a huge fan of the phrase "generic source" - what's generic about it ?

@VioletM VioletM force-pushed the docs/1719-filesystem branch from d1f5d56 to 0add817 Compare September 11, 2024 15:42
akelad
akelad previously approved these changes Sep 11, 2024
Copy link
Contributor

@akelad akelad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay

@akelad akelad self-requested a review September 12, 2024 07:52
@VioletM VioletM merged commit 27539c9 into devel Sep 12, 2024
49 checks passed
@rudolfix rudolfix deleted the docs/1719-filesystem branch October 21, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation sprint Marks group of tasks with core team focus at this moment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Docs | filesystem source makeover Add read_xml example
5 participants