Feat/simplifies naming convention writing #1523
Conversation
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -0,0 +1,34 @@ | |||
| from typing import ClassVar | |||
There was a problem hiding this comment.
these extra files will not show up in the docs, maybe this is ok for now, but we might need to adapt this somehow?
There was a problem hiding this comment.
heh true but people may click in the link and they will go to github. LGTM, for now
| try: | ||
| with open(example_file, "r", encoding="utf-8") as f: | ||
| lines = f.read().split("\n") | ||
| except FileNotFoundError: |
There was a problem hiding this comment.
what is this for? when does this happen?
There was a problem hiding this comment.
something (I think Airflow) creates logs folder in the examples folder when I run any example. this prevents me from refreshing examples and I must remove the logs folder each time
| * `dlt` applies final naming convention in `normalize` step. Naming convention comes from (1) explicit configuration (2) from destination capabilities. | ||
| * Naming convention will be used to put destination is case sensitive/insensitive mode and apply the right case folding function. | ||
|
|
||
| :::caution |
There was a problem hiding this comment.
Maybe we should add here that we do not recommend to change the naming convention for an existing dataset and if need to do it, a fresh load to a new dataset would be the least errorprone.
There was a problem hiding this comment.
this documentation needs at least a day of work...
Description
A followup on #998