improves trackers thread pool #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
sh-rp
previously approved these changes
May 8, 2024
rudolfix
force-pushed
the
rfix/improves-trackers-thread-pool
branch
from
a0486bf to
0c08ed6
Compare
sh-rp
reviewed
May 8, 2024
| @@ -130,7 +130,7 @@ jobs: | |||
| if: runner.os != 'Windows' | |||
| name: Run extract and pipeline tests Linux/MAC | |||
| - run: | | |||
| poetry run pytest tests/extract tests/pipeline tests/libs tests/cli/common tests/destinations | |||
| poetry run pytest tests/extract tests/pipeline tests/libs tests/cli/common tests/destinations -m "not forked" | |||
There was a problem hiding this comment.
why do we need to skip these tests on windows?
There was a problem hiding this comment.
because they are run in fork and that is not available on windows. the test is messing up with global objects
sh-rp
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tracker pools were lazily instantiated. In case of many pipelines running at the same time this could cause problems.