disable qdrant example test and fix snippet errors #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
burnash
reviewed
May 8, 2024
| @@ -58,7 +58,7 @@ from dlt.sources.helpers.rest_client.paginators import JSONResponsePaginator | |||
|
|
|||
| github_client = RESTClient( | |||
| base_url="https://pokeapi.co/api/v2", | |||
| paginator=JSONResponsePaginator(next_url_path="next") # (1) | |||
| paginator=JSONResponsePaginator(next_url_path="next"), # (1) | |||
burnash
reviewed
May 8, 2024
| @@ -191,7 +191,7 @@ E.g. `https://api.example.com/items?offset=0&limit=100`, `https://api.example.co | |||
|
|
|||
| ```json | |||
| { | |||
| "items": [...], | |||
| "items": ["one", "two", "three"], | |||
There was a problem hiding this comment.
Is there a way to leave ellipsis?
There was a problem hiding this comment.
it does not pass json parsing that way.. we can mark the block as text (which will disabled syntax highlighting) or write something like [{}, {}, {}].
There was a problem hiding this comment.
Let's use the strings then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disables failing qdrant example test and fixes some linter errors on snippets