Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove staging-optimized replace strategy for synapse #1231

Merged

Conversation

jorritsandbrink
Copy link
Collaborator

@jorritsandbrink jorritsandbrink commented Apr 16, 2024

Description

Removes staging-optimized replace strategy for synapse destination because it causes deadlocks. This also makes sure the CI tests for synapse can finish correctly.

Related Issues

Additional Context

@jorritsandbrink jorritsandbrink self-assigned this Apr 16, 2024
@jorritsandbrink jorritsandbrink linked an issue Apr 16, 2024 that may be closed by this pull request
Copy link

netlify bot commented Apr 16, 2024

Deploy Preview for dlt-hub-docs canceled.

Name Link
🔨 Latest commit 0ecf487
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/661fba3f862a6e0008deaa06

sh-rp
sh-rp previously approved these changes Apr 17, 2024
Copy link
Collaborator

@sh-rp sh-rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@sh-rp sh-rp merged commit 77e2499 into devel Apr 17, 2024
42 of 46 checks passed
@sh-rp sh-rp deleted the 1229-synapse-staging-optimized-replace-strategy-causes-deadlock branch April 17, 2024 17:55
zem360 pushed a commit that referenced this pull request Apr 17, 2024
* remove staging-optimized replace strategy for synapse

* fix athena iceberg locations

---------

Co-authored-by: Jorrit Sandbrink <[email protected]>
Co-authored-by: Dave <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Synapse staging-optimized replace strategy causes deadlock
2 participants