Fix clipping issue in YearViewSkin header #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The clip for the YearViewSkin was incorrectly set to the yearView rather than the header. This change corrects the clipping to ensure the header is properly clipped according to the yearView's dimensions.
|
dlemmermann
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR addresses an issue where the YearView component was clipped (setClip) to limit the shadow effect only to the bottom of the header. This approach prevented us from adding a shadow effect to the entire YearView component, which is needed to visually distinguish it from the background when used as a popup in the
YearPicker.Changes:
Adjusted clipping to apply only to the header section of YearView, allowing the component to display a shadow.
Issue Fixed: This PR fixes the clipping issue in YearView that previously restricted adding shadows to the entire component.