Add auto-suffix suggestion feature to EmailField #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced a new auto-suffix suggestion feature in the EmailField component to improve user experience. This includes a dropdown suggestion popup, and necessary properties and methods to enable and customize the feature. The demo app has been updated to showcase the new functionality.
Expanded the EmailField JavaDoc to include new features such as automatic email domain suffix suggestions, format validation, and customizable properties for UI elements. These improvements aim to boost user experience and maintain input validity.
This Javadoc provides a clear explanation of the autoSuffixEnabledProperty method, describing its purpose and return value. It improves code documentation and helps future developers understand the function and utility of the method.
dlemmermann
requested changes
Oct 2, 2024
Updated the email suggestions feature to use "domain" terminology instead of "suffix". This change affects property names, internal variables, and user interface components to improve clarity and accuracy in the codebase.
Changed the height property from max-height to pref-height in the email field CSS. This ensures the suggestion list view maintains a consistent height.
Refactor the logic to control the visibility of the email domain suggestion popup and add detailed documentation. The new implementation ensures the popup is shown only under specific conditions and simplifies code readability and maintenance.
|
dlemmermann
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a new auto-suffix suggestion feature in the EmailField component to improve user experience. This includes a dropdown suggestion popup, and necessary properties and methods to enable and customize the feature. The demo app has been updated to showcase the new functionality.