Update mouse event handling and exception throwing in UIUtil #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the clickOnNode method in UIUtil.java to be more specific in handling mouse events. Now, it throws IllegalArgumentException if the event is not a mouse clicked event. Also, refactored the usage of the clickOnNode method in EnhancedPasswordField.java to directly check for primary button click.
dlemmermann
requested changes
Jun 12, 2024
The method names 'clickOnNode' in the UIUtil class were renamed to 'isClickOnNode' to improve readability and understandability, since these methods return a boolean. The code where these methods are called was also updated to reflect this change.
|
dlemmermann
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the clickOnNode method in UIUtil.java to be more specific in handling mouse events. Now, it throws IllegalArgumentException if the event is not a mouse clicked event. Also, refactored the usage of the clickOnNode method in EnhancedPasswordField.java to directly check for primary button click.