Update EnhancedPasswordField functionality and styling #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The EnhancedPasswordField class and its usage have been updated to include CSS pseudo classes for displaying the password. The creation of a simple password field has been simplified to remove unnecessary methods and use better-suited CSS styles for handling the visibility of the password. Moreover, the icon used to toggle the visibility of the password has been changed to be defined in CSS rather than directly in the Java code.
Switched the listener on showPasswordProperty to a subscribe method in the 'EnhancedPasswordField' class. This change promotes cleaner code structure and improves the readability of the EnhancedPasswordField component's code.
dlemmermann
requested changes
Jun 4, 2024
gemsfx/src/main/resources/com/dlsc/gemsfx/enhanced-password-field.css
Outdated
Show resolved
Hide resolved
gemsfx/src/main/java/com/dlsc/gemsfx/EnhancedPasswordField.java
Outdated
Show resolved
Hide resolved
The UI elements for EnhancedPasswordField were updated, specifically replacing a FontIcon with a Region, and modifying the CSS styling for these elements. Additionally, toggle functionality was modified to handle mouse click events correctly.
The clickOnNode method in the UIUtil class has been refactored to check if a mouse event is either a single or a multiple primary button click. An overloaded version of the method now accepts a boolean parameter to specify whether the event should be a single click or not. Additionally, minor fixes were done in the comments and format in UIUtil class. The method MouseClicked in EnhancedPasswordField.java was also modified to utilize the new clickOnNode method.
dlemmermann
requested changes
Jun 10, 2024
gemsfx/src/main/java/com/dlsc/gemsfx/EnhancedPasswordField.java
Outdated
Show resolved
Hide resolved
This commit renamed the "showing" pseudo class to "showing-password" in the EnhancedPasswordField class. The related CSS rules have been updated accordingly. This naming change provides a clearer understanding of the class's function.
Replaced the setOnMouseClicked event handler with a MOUSE_PRESSED event handler in the EnhancedPasswordField class. This will prevent unwanted event propagation when the rightWrapper node is clicked. Added event.consume() to ensure the event is fully processed.
|
dlemmermann
reviewed
Jun 10, 2024
| * @return {@code true} if the event is a stable primary button click, {@code false} otherwise. | ||
| * @throws NullPointerException if the event is null. | ||
| */ | ||
| public static boolean clickOnNode(MouseEvent event, boolean isSingleClick) { |
There was a problem hiding this comment.
"isStillSincePressed" can never be "still". "still" means that the mouse has not been moved between the last two pressed events.
There was a problem hiding this comment.
Thank you for your guidance. After testing, it turned out to be exactly as you said. If it is a mouse press or release, the first triggered event always returns false for isStillSincePress.
dlemmermann
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EnhancedPasswordField class and its usage have been updated to include CSS pseudo classes for displaying the password. The creation of a simple password field has been simplified to remove unnecessary methods and use better-suited CSS styles for handling the visibility of the password. Moreover, the icon used to toggle the visibility of the password has been changed to be defined in CSS rather than directly in the Java code.