History button reworked #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HistoryButton now includes a Node owner parameter, enabling it to be reactive to the focus state of its own parent node. HistoryButton is now linked to its parent node for focus management. The forward-referenced HistoryButton constructor on SearchField and SearchTextField classes, have been updated to include the respective 'this' reference as the owner.
Renamed 'onRemoveAction' method to 'removeItem' and updated the method implementation to improve user interface visibility and event handling. Also included construction documentation for new cells and made some changes to properties binding for proper interaction with visibility and manageability of the cell.
Removed the unused constant DEFAULT_ENABLE_HISTORY_POPUP in the SearchField class to improve code readability and maintenance. This deletion ensures better performance by eliminating unnecessary statements.
|
Thank you for your pr. This elegant and minimalist design is something I should learn from. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.