Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HistoryManager for record management and update SearchField with history support #178

Merged
merged 4 commits into from
May 30, 2024

Conversation

leewyatt
Copy link
Contributor

  • Introduce HistoryManager class to facilitate the management of historical records.
  • Implement history management functionality in SearchField to enhance user interaction.
  • Update SearchTextField with improvements for consistency and performance.

leewyatt and others added 4 commits May 18, 2024 05:20
…history support

- Introduce HistoryManager class to facilitate the management of historical records.
- Implement history management functionality in SearchField to enhance user interaction.
- Update SearchTextField with improvements for consistency and performance.
Introduced filter functionality in HistoryManager to allow only the values passing the filter to be saved in history. In addition, corrected the misdirected reference to the user agent stylesheet in SearchTextField.
Refactored the handling of HistoryManager across several classes for better encapsulation and flexibility. Also, updated 'UIUtil.java', replacing Node parameter with Styleable in all utility methods to handle a wider range of JavaFX styleable components. Lastly, added a 'set' method in the HistoryManager interface and implementations to allow setting a new history list.
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
8.6% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@dlemmermann dlemmermann merged commit 5f940ac into master May 30, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants