Refactor SearchTextField with SearchHistorySupport interface #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated SearchTextField to implement SearchHistorySupport interface, improving modularity and extendability. Removed SearchTextFieldHistoryPopup in favor of more generic SearchHistoryPopup. Renamed related popup skin class and updated references accordingly. Also, created new 'search-history-popup.css' for styling and cleared some unused styles in 'search-text-field.css'.
|
|
I don't like the interface approach in this PR. I think we are trying to hard to find the common parts of two controls that are very differently structured. I think a better approach would be to have the node showing the magnifying class and the down arrow to encapsulate the common logic and to reuse that for both fields. Then the two fields could implement an interface like "HistoryProvider". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated SearchTextField to implement SearchHistorySupport interface, improving modularity and extendability. Removed SearchTextFieldHistoryPopup in favor of more generic SearchHistoryPopup. Renamed related popup skin class and updated references accordingly. Also, created new 'search-history-popup.css' for styling and cleared some unused styles in 'search-text-field.css'.