Enhanced SearchTextField to support search history #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Refactoring of SearchTextField. Major changes include changes to allow the addition of text to the history when the user presses enter. Introduced methods to allow the addition or removal of history items. Added functions to display history popup to the user and its CSS aesthetics were also improved. Another notable change is the creation of a skin class resetting the selection of the ListView by focusing on it and selecting the first item. All these changes aim to provide a better user experience during search functionality.
Removed the resetSelection and show methods in SearchTextFieldHistoryPopup and SearchTextFieldHistoryPopupSkin, and changed the scope of SearchTextField in SearchTextFieldApp. Added new RemovableListCell component with dedicated CSS file. Updated search-text-field.css for hover state.
|
dlemmermann
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No javadoc comments have been added yet.