Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements and Fixes for Notification Component #167

Merged
merged 5 commits into from
May 3, 2024

Conversation

leewyatt
Copy link
Contributor

@leewyatt leewyatt commented May 2, 2024

  1. When a Group contains only one notification and the content of this notification is not empty, an arrow icon should be displayed to facilitate users in clicking to view the content.
  2. Refactor layout request to prevent NullPointerException. Enhance the showContentProperty() listener to use Optional for safe layout request handling. This prevents NullPointerExceptions that occur if the parent is null, which can happen when notifications are expanded by default before their parent container is initialized.
  3. Adjust the position of Actions to the bottom of the notification view.

leewyatt added 5 commits May 3, 2024 01:00
Enhance the showContentProperty() listener to use Optional for safe layout request handling. This prevents NullPointerExceptions that occur if the parent is null, which can happen when notifications are expanded by default before their parent container is initialized.
Copy link

sonarqubecloud bot commented May 3, 2024

@leewyatt leewyatt changed the title Improve User Experience for Notification Display in Single-Item Groups Improvements and Fixes for Notification Component May 3, 2024
@dlemmermann dlemmermann merged commit 9ef2899 into master May 3, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants