Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for nested list binding classes #159

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Add support for nested list binding classes #159

merged 2 commits into from
Apr 29, 2024

Conversation

leewyatt
Copy link
Contributor

1.Add support for nested list binding classes.
2.placeholder to InfoCenterView when there are no notifications.

@leewyatt
1.Add support for nested list binding classes and.
8834bae 
2.placeholder to InfoCenterView when there are no notifications
dlemmermann
dlemmermann requested changes Apr 19, 2024
View reviewed changes
Copy link
Collaborator

@dlemmermann dlemmermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to have unit tests for the binding classes. Very extensive unit tests. Stuff like this is very sensitive and people will hate us when those bindings don't work as expected.

@leewyatt
1. Add ChangeTracker. 2. Add junit test. 3. Add TransformedNestedList…
31280e8 
…Binding. 4. TransformedFlattenedNestedListStreamBinding. 5. Add TransformedNestedListBinding.
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
4 Security Hotspots
0.0% Coverage on New Code (required ≥ 80%)
7.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@dlemmermann dlemmermann merged commit 11bdc67 into master Apr 29, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlemmermann dlemmermann dlemmermann requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leewyatt @dlemmermann