Skip to content

Commit

Permalink
Update dependencies and remove unnecessary excludes
Browse files Browse the repository at this point in the history
Dependency versions have been updated and unnecessary excludes have been removed. Requirement for 'commons.validator' has been replaced with 'org.apache.commons.validator'. Dependencies for 'retrofit2' and 'okttp3' have been removed. 'commons-logging' exclusion has been removed from 'commons-validator' and 'retrofit' in the 'gemsfx' module and from 'gemsfx' in the 'gemsfx-demo' module.
  • Loading branch information
dlemmermann committed May 21, 2024
1 parent b423a9f commit 37c0ea3
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 29 deletions.
7 changes: 0 additions & 7 deletions gemsfx-demo/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -146,12 +146,6 @@
<groupId>com.dlsc.gemsfx</groupId>
<artifactId>gemsfx</artifactId>
<version>2.17.0</version>
<exclusions>
<exclusion>
<groupId>commons-logging</groupId>
<artifactId>commons-logging</artifactId>
</exclusion>
</exclusions>
</dependency>

<dependency>
Expand All @@ -164,7 +158,6 @@
<dependency>
<groupId>commons-logging</groupId>
<artifactId>commons-logging</artifactId>
<version>1.2</version>
</dependency>

<dependency>
Expand Down
20 changes: 1 addition & 19 deletions gemsfx/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -72,25 +72,7 @@
<dependency>
<groupId>commons-validator</groupId>
<artifactId>commons-validator</artifactId>
<version>1.7</version>
<exclusions>
<exclusion>
<groupId>commons-logging</groupId>
<artifactId>commons-logging</artifactId>
</exclusion>
</exclusions>
</dependency>

<dependency>
<groupId>com.squareup.retrofit2</groupId>
<artifactId>retrofit</artifactId>
<version>2.6.1</version>
<exclusions>
<exclusion>
<groupId>commons-logging</groupId>
<artifactId>commons-logging</artifactId>
</exclusion>
</exclusions>
<version>1.8.0</version>
</dependency>

<dependency>
Expand Down
4 changes: 1 addition & 3 deletions gemsfx/src/main/java/module-info.java
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,11 @@
requires java.logging;
requires java.prefs;

requires commons.validator;
requires org.apache.commons.validator;
requires net.synedra.validatorfx;
requires org.apache.commons.lang3;
requires org.controlsfx.controls;

requires retrofit2;
requires okhttp3;
requires java.desktop;
requires com.dlsc.pickerfx;
requires com.dlsc.unitfx;
Expand Down
6 changes: 6 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,12 @@
<version>1.2.0</version>
</dependency>

<dependency>
<groupId>commons-logging</groupId>
<artifactId>commons-logging</artifactId>
<version>1.3.0</version>
</dependency>

<dependency>
<groupId>org.openjfx</groupId>
<artifactId>javafx-graphics</artifactId>
Expand Down

0 comments on commit 37c0ea3

Please sign in to comment.