Tweak README.md #821
Merged
Tweak README.md #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
commented
Oct 6, 2021
| @@ -1,4 +1,4 @@ | |||
| # gulp-sass [](https://github.com/dlmanning/gulp-sass/actions?query=workflow%3ACI+branch%3Amaster) [](https://gitter.im/dlmanning/gulp-sass)   | |||
| # gulp-sass  [](https://github.com/dlmanning/gulp-sass/actions?query=workflow%3ACI+branch%3Amaster) [](https://gitter.im/dlmanning/gulp-sass)  | |||
There was a problem hiding this comment.
The badges' order is subjective, let me know if you want the version one to still be at the end.
xzyfer
reviewed
Oct 6, 2021
README.md
Outdated
Comment on lines
161
to
163
| - var sass = require('gulp-sass')); | ||
| - var compiler = require('sass'); | ||
| - sass.compiler = compiler; |
There was a problem hiding this comment.
this is a diff so I wasn't sure if I should change it...
There was a problem hiding this comment.
Keeping consistent is good. There'll be lots of JS folks who have never been exposed to var before.
There was a problem hiding this comment.
I changed these vars to const.
* switch to shields.io for all badges * use `const` in the JS snippets * fix a http link and a redirect * remove moot spaces around brackets * fix syntax highlighting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
constin the JS snippets