Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make require easier, mention adapter registration #5

Closed
wants to merge 4 commits into from
Closed

make require easier, mention adapter registration #5

wants to merge 4 commits into from

Conversation

jethrodaniel
Copy link

Changes

fix #4

  • Adds lib/faraday-typhoeus.rb for easier require
  • Updates README to mention adapter registration

@jethrodaniel jethrodaniel marked this pull request as ready for review November 4, 2022 21:17
@jethrodaniel
Copy link
Author

Looks like this'll need either a rubocop linter ignore, or we could just rm lib/faraday-typhoeus.rb and tell folks to use require 'faraday/typhoeus'.

@dleavitt
Copy link
Owner

or we could just rm lib/faraday-typhoeus.rb and tell folks to use require 'faraday/typhoeus'

I'd rather do this, to keep the family resemblance btwn this and the other Faraday adapters. How's #6 look?

@jethrodaniel
Copy link
Author

or we could just rm lib/faraday-typhoeus.rb and tell folks to use require 'faraday/typhoeus'

I'd rather do this, to keep the family resemblance btwn this and the other Faraday adapters. How's #6 look?

👍

@dleavitt
Copy link
Owner

closed in favor of #6

@dleavitt dleavitt closed this Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mentioning the registering of the adapter
2 participants