-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable] Upgrade CI configuration following macOS-11 deprecation #2933
Conversation
✅ PR OK, no changes in deprecations or warnings Total deprecations: 0 Total warnings: 0 Build statistics: statistics (-before, +after)
executable size=5242696 bin/dub
-rough build time=60s
+rough build time=61s Full build output
|
c00fb9c
to
ec8b58f
Compare
@jacob-carlborg : Any chance you could take a look ? I don't have a Macbook anymore so I haven't kept on top of things. I'm mostly concerned about whether there's a bugfix needed in Dub or the test just need to be adjusted ? |
@Geod24 I can take a quick look, but I'm lazy. How do I run the tests? |
This is what we do on POSIX: dub/.github/workflows/main.yml Lines 100 to 109 in dd94e48
In particular, |
@Geod24 I gave it a quick try, I can't easily get it to work. Probably because I have an Apple Silicon Mac. I'm not the only one with a Mac. Both @schveiguy and @thewilsonator are using Mac. At least the last time I met them. I'm sure there are others as well. Alternatively you can use this action [1] to get a shell into the runner and debug it from there. |
59bef04
to
0bdb9a7
Compare
Long story short: |
842c542
to
7fde489
Compare
macOS-11 is going away at the end of June. As a consequence, we upgrade to macOS-12, upgrade the supported frontend versions, and add some arm64 tests to prepare for future upgrades.
@Geod24 why not bump to macOS 13 while you're at it? |
We test (and release) on the oldest available runner. My understanding is that you can run a macOS-12 binary on 13 but not the other way around unless you set the SDK version explicitly? |
Yes, that's correct. I would use the latest runner (latest for x86-64) and set the minimum deployment target. Then we're in control of which platforms we want to support. Also less often the runner version needs to be bumped. Set the |
macOS-14 is out so we could probably bump to that. I'll give it a shot in the not-so-distant future - this was really just a band-aid as we were hit by macOS-11 brownout when trying to merge other MRs. |
The macOS-14 runner is ARM64 only, unless GitHub added x86-64 recently. |
Yeah, I've learned the hard way that, if you can, stay on |
macOS-11 is going away at the end of June.