Unify reading and writing files under a single API #2517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-ludwig
reviewed
Oct 28, 2022
| RangeFile openFile(string path, FileMode mode = FileMode.read) | ||
|
|
||
| /// Returns the content of a file | ||
| public void[] readFile(NativePath path) |
There was a problem hiding this comment.
Should probably return ubyte[], even if that makes no difference to the GC, but it would match vibe.d's readFile. Or do you want to implement vibe.d compatibility with the planned dependency injection interface?
There was a problem hiding this comment.
I originally used void[] because that's what std.file returns, but I agree that's probably better.
WebFreak001
previously requested changes
Oct 29, 2022
This removes the range API and instead uses Appender, while using a limited and centralized set of functions to read/write from files. The end goal is to permit dependency injection, which is a pre-requisite to extending the test-suite.
|
Rebased and changed appender |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the range API and instead uses Appender, while using a limited and centralized set of functions to read/write from files.
The end goal is to permit dependency injection,
which is a pre-requisite to extending the test-suite.