Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dub: Use removeFile instead of std.file.remove #2516

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Dub: Use removeFile instead of std.file.remove #2516

merged 1 commit into from
Oct 28, 2022

Conversation

Geod24
Copy link
Member

@Geod24 Geod24 commented Oct 28, 2022

In the end it calls the same function, but this allow us to consistently inject dependencies.

@Geod24
Dub: Use removeFile instead of std.file.remove
98dc59e 
In the end it calls the same function, but this allow us
to consistently inject dependencies.
@Geod24 Geod24 requested a review from WebFreak001 October 28, 2022 16:54
@thewilsonator thewilsonator merged commit 14568dc into dlang:master Oct 28, 2022
@Geod24 Geod24 deleted the std-file-remove branch October 29, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewilsonator thewilsonator thewilsonator approved these changes

@WebFreak001 WebFreak001 Awaiting requested review from WebFreak001

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Geod24 @thewilsonator