Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return null instead of empty array #2492

Merged
merged 1 commit into from
Oct 15, 2022
Merged

Return null instead of empty array #2492

merged 1 commit into from
Oct 15, 2022

Conversation

skoppe
Copy link
Contributor

@skoppe skoppe commented Oct 15, 2022

Silly change to get my account verified

@Geod24
Copy link
Member

Geod24 commented Oct 15, 2022

Damn it I broke the nightlies again...

Copy link
Member

@WebFreak001 WebFreak001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code change looks reasonable, but how does this help you verify your account?

@Geod24 Geod24 merged commit cfb6f23 into dlang:master Oct 15, 2022
@Geod24
Copy link
Member

Geod24 commented Oct 15, 2022

@WebFreak001 : First time contributors (people without a PR merged) need to have someone with merge access click "Approve and Run" for the CI to run. And every time they push something new, you have to click "Approve and Run" again. It's ridiculous.

@WebFreak001
Copy link
Member

WebFreak001 commented Oct 15, 2022

that doesn't answer my question though, also the CI was already running without me doing anything here :p

@Geod24
Copy link
Member

Geod24 commented Oct 15, 2022

Because I approved it.

@Geod24
Copy link
Member

Geod24 commented Oct 15, 2022

that doesn't answer my question though

@skoppe has another PR which is substantial. Everytime he does a change and push, CI doesn't run, because he doesn't have a commit in master yet. Now he has a commit in master, so CI will run.

@WebFreak001
Copy link
Member

oh right that makes sense then, I thought this had something to do with meson package search somewhere explicitly requiring null, which would have been weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants