Improve PackageOverride API, deprecate Dependency.versionSpec
#2366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geod24
force-pushed
the
discriminate
branch
2 times, most recently
from
720bf79 to
2b9dda6
Compare
Like Dependency, we only were using one of those two fields, but it was not readily obvious before, and we relied on one of them being empty to read the other one.
The code was always assuming overrides were VersionRange, as trying to do 'dub add-override' would call 'Dependency' constructor with a string, which forwards to VersionRange.fromString. However, when using dub as a library, this assumption was much less obvious, notably because the fields are public. With this change, we make sure library users do not misuse overrides.
All places which assumed that Dependency contained a VersionRange have been culled, so we can now start removing those properties.
thewilsonator
approved these changes
Aug 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to weed out all the place that made any kind of assumption about what's a
Dependency.While the diff looks pretty terrible because I'm trying very hard not to break code for library users, the result is that
versionSpecis no longer used within dub, and I think the resulting (non-deprecated) code is much nicer and easier to read.