Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

made return codes more consistent + improved man page format #2365

Merged
merged 2 commits into from
Aug 6, 2022
Merged

made return codes more consistent + improved man page format #2365

merged 2 commits into from
Aug 6, 2022

Conversation

WebFreak001
Copy link
Member

before:

after:

Geod24
Geod24 reviewed Aug 5, 2022
View reviewed changes
changelog/exitcodes.dd Outdated Show resolved Hide resolved
Geod24
Geod24 reviewed Aug 5, 2022
View reviewed changes
changelog/exitcodes.dd Outdated Show resolved Hide resolved
Geod24
Geod24 reviewed Aug 5, 2022
View reviewed changes
changelog/exitcodes.dd Outdated Show resolved Hide resolved
Geod24
Geod24 reviewed Aug 5, 2022
View reviewed changes
changelog/exitcodes.dd
Comment on lines +7 to +11
- dub clean
- dub add
- dub search
- dub convert

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- dub clean
- dub add
- dub search
- dub convert
- dub clean
- dub add
- dub search
- dub convert

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this suggestion is invalid because no changes were made to the code

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove trailing line

@Geod24
Copy link
Member

Geod24 commented Aug 5, 2022

Hum shouldn't the exit code change be in its own PR / at least its own commit ? It's quite unrelated to the commit title.

@WebFreak001
Copy link
Member Author

split into 2 commits

@WebFreak001 WebFreak001 changed the title improve man page format made return codes more consistent + improved man page format Aug 5, 2022
@Geod24 Geod24 merged commit d74fae4 into dlang:master Aug 6, 2022
@WebFreak001 WebFreak001 mentioned this pull request Aug 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Geod24 Geod24 Geod24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WebFreak001 @Geod24