Merge stable #2299
Merged
Merge stable #2299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses exact version matching instead of SemVer matching for cached packages to enforce exact matches for SCM based dependencies in particular.
… the need to fetch a dependency. Fixes dlang#2262.
…ion_match Match versions of cached packages exactly
Conflicts: source/dub/dependency.d
kinke
commented
Jul 13, 2022
| if (this.matchesAny) return true; | ||
| if (this.isSCM) return true; | ||
| if (this.isExactVersion && mode == VersionMatchMode.strict | ||
| && this.version_.toString != v.toString) | ||
| return false; | ||
| return this.m_range.matches(v); |
There was a problem hiding this comment.
This was refactored in master in the meantime. I moved the strict check before the new VersionRange.matches() call. Maybe the latter should get a new VersionMatchMode param and handle it itself?
There was a problem hiding this comment.
Probably, but the current version should work just fine, even if it's a bit ugly.
Geod24
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.