-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Posix: use /etc/dub/settings.json if in /usr #2203
Conversation
another idea would be to have /etc/dub.conf which could be considered better than /etc/dub/settings.json because dub only has a single config file (and probably won't get much more that belongs in /etc) |
Yeah I think |
I disagree. |
I would suggest dub.conf - maybe it should be a SDL file too though |
960f3ca
to
8d22ca4
Compare
I asked on the discord and got these preferences by users: (mostly weak preferences)
adr doesn't really care but after asking about So I would be for putting it in The reasons that most influenced me on this decision: (in this order)
|
I do like This does need documenting though. |
Fix dlang#1472 /etc/dub/settings.json overrides /usr/etc/dub/settings.json (as suggested by the `man hier` manpage)
8d22ca4
to
8d494a5
Compare
@rikkimax added changelog entry and made PR to dub-docs (though I doubt that PRs there will be merged any time soon with deployment being broken) |
I'm on board with |
can someone approve the PR so I can merge it? |
Moving towards the XDG standard is preferable tho. |
I think how I PRd it here is best for how the current structure is. So if anyone could approve the PR that would be nice. |
Right, my bad. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the change, but I'm not part of dub development and I may miss something, although LGTM.
ok seems like I would need someone of the dub team to approve to be able to merge |
Fix #1472
/etc/dub/settings.json overrides /usr/etc/dub/settings.json (as
suggested by the
man hier
manpage)