Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -fno-druntime to GDC BuildOptions; it is the betterC flag. #2186

Merged
merged 2 commits into from
Apr 15, 2022
Merged

Add -fno-druntime to GDC BuildOptions; it is the betterC flag. #2186

merged 2 commits into from
Apr 15, 2022

Conversation

ibara
Copy link
Contributor

@ibara ibara commented Oct 18, 2021

Take 2, based off of master rather than stable since I'm not sure what happened with the testing apparatus there in #2185.

This is a partial fix for #2184.
Confirmed to fix the previously failing test on OpenBSD.

WebFreak001
WebFreak001 approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@WebFreak001 WebFreak001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you want to add any other flags that aren't present yet if there are any that are missing that you know of?

@ibuclaw
Copy link
Member

ibuclaw commented Oct 18, 2021 •
edited
Loading

do you want to add any other flags that aren't present yet if there are any that are missing that you know of?

Just having a quick scan of existing flags.

  • -fd-verbose doesn't exist, use -v.
  • -fdebug-c doesn't exist, use -g.
  • -fXf= doesn't exist, use -Xfdocs.json
  • -O3 is a terrible idea (there are dozens of papers and talks that say it either makes things worse, or gains don't justify the added compilation times), use -O2.

@ibara
Tweak additional flags at Iain's recommendation:
4b42e29 
-fd-verbose becomes -v
-fdebug-c doesn't exist, remove (-g is still there)
-fXf= becomes -Xf
Replace -O3 with -O2
@ibara
Copy link
Contributor Author

ibara commented Oct 18, 2021

Made the changes. Particularly happy to change -O3 to -O2.

@ibuclaw
Copy link
Member

ibuclaw commented Apr 15, 2022

No idea why CI is stuck, but there's nothing controversial here.

@ibuclaw ibuclaw merged commit 0046dbd into dlang:master Apr 15, 2022
@ibara ibara deleted the gdc-betterC branch April 15, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibuclaw ibuclaw ibuclaw left review comments

@WebFreak001 WebFreak001 WebFreak001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ibara @ibuclaw @WebFreak001