Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability for specify version range for commandline commands #2056

Merged
merged 1 commit into from
Dec 8, 2020

Conversation

deviator
Copy link
Contributor

@deviator deviator commented Dec 5, 2020

no breaking changes expected

@dlang-bot
Copy link
Collaborator

Thanks for your pull request and interest in making D better, @deviator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

@deviator
Copy link
Contributor Author

deviator commented Dec 6, 2020

ping @Geod24
I don't sure what this change will be useful for many people, but I think it can be helpful when dub integrates with other systems (IDE or buildsystems).

@deviator deviator closed this Dec 7, 2020
@deviator deviator reopened this Dec 7, 2020
@deviator
Copy link
Contributor Author

deviator commented Dec 7, 2020

ping @thewilsonator, this change like #2057, but for other commands

@Geod24
Copy link
Member

Geod24 commented Dec 7, 2020

Sounds useful, will review now.

Copy link
Member

@Geod24 Geod24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the affected / unaffected commands ?

@deviator deviator closed this Dec 7, 2020
@deviator deviator reopened this Dec 7, 2020
@deviator
Copy link
Contributor Author

deviator commented Dec 7, 2020

CyberShadow/DAutoTest failed:

posix.mak:807: recipe for target 'test' failed
make: *** [test] Error 1
Test failed: object.Exception@ae/sys/d/manager.d(877): Command ["timeout", "1800", "make", "-f", "posix.mak", "DIFFABLE=1", "test"] failed with status 2

but in log before

posix.mak:42: ===== DEPRECATION NOTICE ===== 
posix.mak:43: ===== DEPRECATION: posix.mak is deprecated. Please use src/build.d instead.
posix.mak:44: ============================== 

may it depends?

@Geod24
Copy link
Member

Geod24 commented Dec 7, 2020

The failure is because the changelog have trailing whitespace. I'll take a look.

@Geod24 Geod24 force-pushed the improve-version-spec-ability branch from 5a3bf53 to b1897fe Compare December 7, 2020 23:38
As mentioned in the changelog, it was not possible with all commands.
No breaking changes are expected.
@Geod24 Geod24 force-pushed the improve-version-spec-ability branch from b1897fe to cfa0461 Compare December 7, 2020 23:38
@Geod24
Copy link
Member

Geod24 commented Dec 7, 2020

Should be fixed now. Also rebased on master for you and squashed commits.

@dlang-bot dlang-bot merged commit 0621b1b into dlang:master Dec 8, 2020
@deviator deviator deleted the improve-version-spec-ability branch December 8, 2020 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants