Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont export DFLAGS & LFLAGS by default #2048

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

omerfirmak
Copy link
Contributor

DFLAGS and LFLAGS will not be exported as environment variables by default.
They can be accessed with $DFLAGS and $LFLAGS variables in dub.json

Eg;

preGenerateCommands : ["DFLAGS=$DFLAGS env | grep DFLAGS"]

will output DFLAGS environment variable with all the dflags used.

@dlang-bot
Copy link
Collaborator

Thanks for your pull request and interest in making D better, @omerfirmak! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

source/dub/project.d Outdated Show resolved Hide resolved
@Geod24 Geod24 force-pushed the agora-1323-dont-propagate-flags branch from c64b13a to 4c6a19e Compare December 7, 2020 17:02
@dlang-bot dlang-bot merged commit 13123f6 into dlang:master Dec 7, 2020
@omerfirmak omerfirmak deleted the agora-1323-dont-propagate-flags branch December 7, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants