Merge pull request #1918 from Calrama/fixmemleak

Fix leaking memory in shared druntime
dlang · Sep 23, 2017 · 4ee4569 · 4ee4569
2 parents 95fd6e1 + c04a506
commit 4ee4569
Showing 1 changed file with 16 additions and 3 deletions.
diff --git a/src/rt/sections_elf_shared.d b/src/rt/sections_elf_shared.d
@@ -455,7 +455,6 @@ extern(C) void _d_dso_registry(CompilerDSOData* data)
             }
 
             unsetDSOForHandle(pdso, pdso._handle);
-            pdso._handle = null;
         }
         else
         {
@@ -466,7 +465,16 @@ extern(C) void _d_dso_registry(CompilerDSOData* data)
 
         freeDSO(pdso);
 
-        if (_loadedDSOs.empty) finiLocks(); // last DSO
+        // last DSO being unloaded => shutdown registry
+        if (_loadedDSOs.empty)
+        {
+            version (Shared)
+            {
+                assert(_handleToDSO.empty);
+                _handleToDSO.reset();
+            }
+            finiLocks();
+        }
     }
 }
 
@@ -599,7 +607,12 @@ version (Shared) void runFinalizers(DSO* pdso)
 void freeDSO(DSO* pdso) nothrow @nogc
 {
     pdso._gcRanges.reset();
-    version (Shared) pdso._codeSegments.reset();
+    version (Shared)
+    {
+        pdso._codeSegments.reset();
+        pdso._deps.reset();
+        pdso._handle = null;
+    }
     .free(pdso);
 }