-
-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FileManager redux: replace FileCache with FileManager #13193
Conversation
Thanks for your pull request and interest in making D better, @hatf0! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#13193" |
Actually, gdc is a cool kid and integrates with gcc diagnostics, not the loser dmd ones, so keep it private to D please. |
b4c083b
to
862b4f5
Compare
@ibuclaw added the requested fixes -- let me know what you think |
FWIW, for anyone wondering, it looks like |
5f424da
to
735c522
Compare
7423d0c
to
9522451
Compare
9522451
to
97c5a0b
Compare
Sorry, no time for properly reviewing this, but after an extremely superficial glance, it doesn't look like LDC will be affected (it has a somewhat modified |
This PR caused a regression https://issues.dlang.org/show_bug.cgi?id=22816 |
This PR seeks to take the work in #12037 and revive the work done to replace the near-useless
FileCache
struct indmd/filecache.d
.Why?
filecache.d
has a lot of issues. It:-verrors=context
by default (Enable -verrors=context by default #13174), related to the fact that it only supported reading files from disk (i.e.dmd.errors.verrorPrint
throwing an exception because it was not able to find__stdin.d
)-verrors=context
to workThe work done in #12037 was very much on the right track, but was abandoned (seemingly due to a lack of interest or something else). This seeks to address all of the issues with
filecache.d
, and integrate it into the compiler (taking into account all criticism that was given to the PR).With merging this PR:
extractSlice
) -- what benefit this has is TBDDo let me know if this needs further unittesting.