-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix grammar documentation generation #518
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DCD BUILD FAILED Build statistics: ------ libdparse statistics ------
statistics (-before, +after)
-library size=3176268 libdparse.a
+library size=3175908 libdparse.a
rough build time=12s
------ DCD statistics ------
statistics (-before, +after)
client size=1052480 bin/dcd-client
server size=3110200 bin/dcd-server
-rough build time=59s
+rough build time=60s
-DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:07.82
-DCD run_tests.sh Maximum resident set size (kbytes): 43060
+DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:08.05
+DCD run_tests.sh Maximum resident set size (kbytes): 47252
short requests: (240x)
- min request time = 0.006ms
- 10th percentile = 0.156ms
- median time = 0.348ms
- 90th percentile = 0.651ms
- max request time = 1.541ms
+ min request time = 0.013ms
+ 10th percentile = 0.150ms
+ median time = 0.399ms
+ 90th percentile = 0.654ms
+ max request time = 1.791ms
long requests over 10ms: (51x)
- min request time = 11.611ms
- 10th percentile = 12.522ms
- median time = 13.765ms
- 90th percentile = 15.319ms
- max request time = 21.442ms
+ min request time = 13.299ms
+ 10th percentile = 13.697ms
+ median time = 15.399ms
+ 90th percentile = 18.851ms
+ max request time = 22.126ms
top 5 GC sources in server: Full build output
|
WebFreak001
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good find
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue comes from ddox tokenizer that seems to have a bug when escaped quotes appear in token strings.
I guess a long-term solution would be to report and fix the bug directly in ddox