fix tokens slices for some special parse methods #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
✅ PR OK, no changes in deprecations or warnings Total deprecations: 0 Total warnings: 0 Build statistics: ------ libdparse statistics ------
statistics (-before, +after)
-library size=3520844 libdparse.a
+library size=3523372 libdparse.a
rough build time=16s
------ DCD statistics ------
statistics (-before, +after)
client size=1055840 bin/dcd-client
server size=3069184 bin/dcd-server
rough build time=76s
-DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:08.23
-DCD run_tests.sh Maximum resident set size (kbytes): 43780
+DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:08.24
+DCD run_tests.sh Maximum resident set size (kbytes): 43604
short requests: (228x)
- min request time = 0.007ms
- 10th percentile = 0.126ms
- median time = 0.435ms
- 90th percentile = 0.745ms
- max request time = 1.480ms
+ min request time = 0.008ms
+ 10th percentile = 0.112ms
+ median time = 0.423ms
+ 90th percentile = 0.737ms
+ max request time = 2.981ms
long requests over 10ms: (51x)
- min request time = 16.598ms
- 10th percentile = 16.910ms
- median time = 18.060ms
- 90th percentile = 20.951ms
- max request time = 27.658ms
+ min request time = 16.142ms
+ 10th percentile = 16.640ms
+ median time = 17.883ms
+ 90th percentile = 20.453ms
+ max request time = 27.002ms
top 5 GC sources in server:
bytes allocated, allocations, type, function, file:line
- 88388608 842 void[] std.array.Appender!(const(TokenStructure!(ubyte, "import dparse.lexer:TokenTriviaFields,TriviaToken; mixin TokenTriviaFields;"))[]).Appender.ensureAddable.__lambda9 /opt/hostedtoolcache/dc/dmd-2.104.0/x64/dmd2/linux/bin64/../../src/phobos/std/array.d:3634
+ 84038656 842 void[] std.array.Appender!(const(TokenStructure!(ubyte, "import dparse.lexer:TokenTriviaFields,TriviaToken; mixin TokenTriviaFields;"))[]).Appender.ensureAddable.__lambda9 /opt/hostedtoolcache/dc/dmd-2.104.0/x64/dmd2/linux/bin64/../../src/phobos/std/array.d:3634
14241024 163616 void[] std.array.Appender!(DSymbol*[]).Appender.ensureAddable.__lambda9 /opt/hostedtoolcache/dc/dmd-2.104.0/x64/dmd2/linux/bin64/../../src/phobos/std/array.d:3634
9770656 305333 std.array.Appender!(immutable(char)[]).Appender.Data std.array.Appender!string.Appender.this /opt/hostedtoolcache/dc/dmd-2.104.0/x64/dmd2/linux/bin64/../../src/phobos/std/array.d:3509
7371696 279 ubyte[] msgpack.unpacker.Unpacker.InternalBuffer!().initializeBuffer ../../../../.dub/packages/msgpack-d-1.0.4/msgpack-d/src/msgpack/common.d:628
7101600 5918 immutable(char)[][immutable(char)[]] dsymbol.ufcs.typeWillBeUpcastedTo dsymbol/src/dsymbol/ufcs.d:292Full build output |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #495 +/- ##
=======================================
Coverage 84.27% 84.28%
=======================================
Files 11 11
Lines 8533 8556 +23
=======================================
+ Hits 7191 7211 +20
- Misses 1342 1345 +3
Continue to review full report in Codecov by Sentry.
|
WebFreak001
force-pushed
the
range-fixes
branch
2 times, most recently
from
35f235e to
0198085
Compare
fixes FunctionCallExpression to include its type, FunctionDeclaration to include its type, IndexExpression to include its unary expression, fish operators, etc are fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes FunctionCallExpression to include its type, FunctionDeclaration to include its type, IndexExpression to include its unary expression, fish operators, etc are fixed.
Tests for this are in D-Scanner: dlang-community/D-Scanner#904