attach token location to error tokens #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes invalid strings error at proper location instead of at 0,0 See confusion in https://forum.dlang.org/post/[email protected]
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #483 +/- ##
==========================================
+ Coverage 83.20% 83.45% +0.25%
==========================================
Files 11 11
Lines 8423 8454 +31
==========================================
+ Hits 7008 7055 +47
+ Misses 1415 1399 -16
Continue to review full report at Codecov.
|
WebFreak001
commented
Feb 9, 2023
There was a problem hiding this comment.
since checking for error tokens is done by comparing == tok!"", which only checks the .type property, this should be fully backwards compatible both for valid code and invalid code.
As a result of this PR incomplete strings, broken character literals, etc. now show proper error position when doing things such as x = ''; inside void main() {} in the parser code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes invalid strings error at proper location instead of at 0,0
See confusion in https://forum.dlang.org/post/[email protected]