Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IfCondition to while (since DMD-FE 2.097.0) #462

Merged
merged 4 commits into from
Jun 20, 2022

Conversation

WebFreak001
Copy link
Member

@WebFreak001 WebFreak001 requested a review from Hackerpilot June 3, 2022 10:27
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #462 (b6e96bb) into master (b94a157) will increase coverage by 0.31%.
The diff coverage is 85.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #462      +/-   ##
==========================================
+ Coverage   82.86%   83.17%   +0.31%     
==========================================
  Files          11       11              
  Lines        8321     8338      +17     
==========================================
+ Hits         6895     6935      +40     
+ Misses       1426     1403      -23     
Impacted Files Coverage Δ
src/dparse/parser.d 91.30% <72.72%> (+<0.01%) ⬆️
src/dparse/astprinter.d 94.31% <78.57%> (-0.45%) ⬇️
src/dparse/formatter.d 45.93% <95.45%> (+2.00%) ⬆️
src/dparse/ast.d 70.85% <100.00%> (+0.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b94a157...b6e96bb. Read the comment docs.

@WebFreak001 WebFreak001 force-pushed the add-while-condition branch from 2392108 to 37ed9fa Compare June 20, 2022 16:42
@WebFreak001
Copy link
Member Author

added more exhaustive tests and added support for scope, going to merge in

@WebFreak001 WebFreak001 merged commit 19a8489 into dlang-community:master Jun 20, 2022
@WebFreak001 WebFreak001 deleted the add-while-condition branch May 4, 2023 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

serve-d complains when on assignment in conditional expression
1 participant