-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lexer: avoid unnecessary allocations on compile-time arrays #449
lexer: avoid unnecessary allocations on compile-time arrays #449
Conversation
There is no CI? |
Doesn't look like it, hasn't been swapped over from Travis to GH actions. |
seems to fail with GDC |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #449 +/- ##
=======================================
Coverage 83.59% 83.59%
=======================================
Files 11 11
Lines 8478 8478
=======================================
Hits 7087 7087
Misses 1391 1391
Continue to review full report in Codecov by Sentry.
|
I think this should be accepted by the compiler. I can add |
Signed-off-by: Luís Ferreira <[email protected]>
45d20f6
to
6883639
Compare
DCD BUILD FAILED Build statistics: ------ libdparse statistics ------
statistics (-before, +after)
-library size=3544860 libdparse.a
-rough build time=22s
+library size=3517908 libdparse.a
+rough build time=19s
------ DCD statistics ------
statistics (-before, +after)
client size=1055832 bin/dcd-client
server size=3052720 bin/dcd-server
-rough build time=95s
+rough build time=91s
DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:06.10
-DCD run_tests.sh Maximum resident set size (kbytes): 10708
+DCD run_tests.sh Maximum resident set size (kbytes): 9020
short requests: (217x)
- min request time = 0.010ms
- 10th percentile = 0.151ms
- median time = 0.540ms
- 90th percentile = 0.987ms
- max request time = 2.344ms
+ min request time = 0.019ms
+ 10th percentile = 0.154ms
+ median time = 0.538ms
+ 90th percentile = 0.908ms
+ max request time = 1.872ms
top 5 GC sources in server: Full build output
|
23d97d0
to
b20de17
Compare
b20de17
to
27ae689
Compare
DCD build failure is due to issues.dlang.org/show_bug.cgi?id=23874 |
Signed-off-by: Luís Ferreira [email protected]