Support parsing named function and template arguments. #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #436 +/- ##
==========================================
+ Coverage 83.48% 83.53% +0.04%
==========================================
Files 11 11
Lines 8484 8527 +43
==========================================
+ Hits 7083 7123 +40
- Misses 1401 1404 +3
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
D added support for that in master, should be merged before next version
cc @WebFreak001 |
|
thanks! This is gonna be quite an exciting change. Further things on the roadmap:
Will review and adjust this PR |
WebFreak001
force-pushed
the
named-arguments
branch
from
549cee6 to
45ddac7
Compare
|
DCD BUILD FAILED Build statistics: ------ libdparse statistics ------
statistics (-before, +after)
-library size=3511132 libdparse.a
+library size=3542452 libdparse.a
rough build time=16s
------ DCD statistics ------
statistics (-before, +after)
client size=1055768 bin/dcd-client
-server size=3018608 bin/dcd-server
+server size=3035696 bin/dcd-server
rough build time=76s
-DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:05.90
-DCD run_tests.sh Maximum resident set size (kbytes): 9928
+DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:05.88
+DCD run_tests.sh Maximum resident set size (kbytes): 14096
-short requests: (219x)
- min request time = 0.009ms
- 10th percentile = 0.131ms
- median time = 0.448ms
- 90th percentile = 0.735ms
- max request time = 2.531ms
+short requests: (217x)
+ min request time = 0.008ms
+ 10th percentile = 0.134ms
+ median time = 0.436ms
+ 90th percentile = 0.738ms
+ max request time = 1.404ms
top 5 GC sources in server:Full build output |
WebFreak001
approved these changes
Apr 5, 2023
There was a problem hiding this comment.
since the spec can't be expected to be updated until like a few compiler release cycles later (it's already in the latest release, changelog only coming next release though) I think we can just merge this as-is, since it matches with the DIP grammar changes.
DMD at least seems to match the libdparse parsing implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/dlang/DIPs/blob/master/DIPs/accepted/DIP1030.md
The DIP mentions changing the definition of the
ArgumentListrule, but that would cause problems in places such as case statements, mixins, index expression, and several others. I'll need to make sure that the pull request to the grammar spec is correct when it happens. A few other rules should be changed to use the newNamedArgumenList, and others need to continue usingArgumentList.